Always enable load balancing #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrwyattii
suggested changes
Jun 26, 2023
There was a problem hiding this comment.
I think we should also remove the enable_load_balancing pytest fixture.
Additionally, we should ensure that MII will work correctly if a hostfile is not specified. In the tests, we generate the hostfile, but perhaps this sort of functionality should be embedded in MII so that users are not required to generate one (especially if they are using just a single replica)
tohtana
reviewed
Jun 26, 2023
tohtana
reviewed
Jun 26, 2023
mrwyattii
approved these changes
Jun 27, 2023
mrwyattii
approved these changes
Jun 27, 2023
tohtana
approved these changes
Jun 27, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always enable load balancing