Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing pydantic updates in legacy mii code #524

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Fix missing pydantic updates in legacy mii code #524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mii/legacy/deployment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,12 @@ def support_legacy_api(
}
# TODO do this in a single for loop
for key, val in mii_config.items():
if key not in MIIConfig.fields.keys():
if key not in MIIConfig.model_fields.keys():
model_config[key] = val
mii_config = {
k: v
for k,
v in mii_config.items() if k in MIIConfig.__dict__["__fields__"]
v in mii_config.items() if k in MIIConfig.model_fields.keys()
}
mii_config["version"] = version
mii_config["deployment_type"] = deployment_type
Expand Down