Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null Pointer Exception: Migrated manipulation handlers can persist components that expect manipulation handlers to exist, despite being removed. #7465

Closed
provencher opened this issue Mar 1, 2020 · 0 comments · Fixed by #7480
Closed

Null Pointer Exception: Migrated manipulation handlers can persist components that expect manipulation handlers to exist, despite being removed. #7465

provencher opened this issue Mar 1, 2020 · 0 comments · Fixed by #7480
Assignees
@keveleigh
Labels
Bug UX Controls - ObjectManipulator formerly known as ManipulationHandler
Milestone
MRTK 2.4.0

Comments

@provencher
Copy link
Contributor

Describe the bug

Migrated manipulation handlers can persist components that expect manipulation handlers to exist, despite being removed.

To reproduce

When interacting with migrated manipulation handlers, there may be a crash.

Expected behavior

No null pointer exception.

Screenshots

image

CursorContextManipulationHandler - seems to depend on ManipulationHandler, but does not ensure the component is present.
image

Your setup (please complete the following information)

  • Unity Version 2018.4.17f1
  • MRTK Version - latest dev branch

Target platform (please complete the following information)

  • Oculus Quest
@provencher provencher added the Bug label Mar 1, 2020
@Troy-Ferrell Troy-Ferrell added the UX Controls - ObjectManipulator formerly known as ManipulationHandler label Mar 2, 2020
@keveleigh keveleigh mentioned this issue Mar 3, 2020
Merged
@keveleigh keveleigh self-assigned this Mar 3, 2020
@keveleigh keveleigh added this to the MRTK 2.4.0 milestone Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keveleigh keveleigh

Labels
Bug UX Controls - ObjectManipulator formerly known as ManipulationHandler
Projects
None yet
Milestone
MRTK 2.4.0
Development

Successfully merging a pull request may close this issue.

Add RequireComponent to CursorContextManipulationHandler keveleigh/HoloToolkit-Unity
3 participants
@keveleigh @provencher @Troy-Ferrell