Add RequireComponent to CursorContextManipulationHandler #7480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keveleigh
added
UX Controls - ObjectManipulator
keveleigh
requested review from
CDiaz-MS,
david-c-kline,
julenka,
thalbern and
wiwei
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Troy-Ferrell
reviewed
Mar 4, 2020
Assets/MixedRealityToolkit.Tests/PlayModeTests/BaseCursorTests.cs
Outdated
Show resolved
Hide resolved
Troy-Ferrell
approved these changes
Mar 4, 2020
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
I didn't know CursorContextManipulationHandler existed 😱 - will add follow up item to make sure we're handling this as well for ObjectManipulator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This will prevent the migration step from running, as of #7244.
This fixes the case where this script assumed the presence of ManipulationHandler. I chose this fix over
EnsureComponent, because we have existing code that prevents migration based onRequireComponent.Changes