Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRTK3] Poke scrolling - WIP #10795

Closed
wants to merge 10 commits into from
Closed

Conversation

Zee2
Copy link
Contributor

@Zee2 Zee2 commented Jul 28, 2022

Overview

Introduces poke scrolling to ScrollRects. Very WIP.

Fixes #10736

  • Ray scrolling is... no bueno, if not using the native UGUI raycast route. XRI doesn't bubble up, sooooo.... hard challenge
  • Gazepinch scrolling has the same issue as above
  • Thinking about a good way to cancel button press visuals during a scroll (easier to cancel the events, not so easy to cancel the visuals)

@Zee2 Zee2 marked this pull request as draft July 28, 2022 00:03
@Zee2
Copy link
Contributor Author

Zee2 commented Jul 28, 2022

@SimonDarksideJ, here's the experimental scrolling work I've been doing. It's focused on finger scrolling first and foremost, mostly because doing bubble-up ray scrolling is extra tricky. We'll track work on scrolling through this PR, so, stay tuned :)

@Zee2 Zee2 self-assigned this Aug 2, 2022
@Zee2 Zee2 added UX Controls - Scroll View Feature Graduation Label tracking graduating features from experimental MRTK3 labels Aug 2, 2022
@Zee2 Zee2 added this to the MRTK3 milestone Aug 2, 2022
Jadocee added a commit to Jadocee/ARPort-High-Fidelity-Prototype that referenced this pull request Sep 29, 2022
Removed scroll view for tabs (WIP; see microsoft/MixedRealityToolkit-Unity#10795)

Fixed tab displaying wrong page

Added a title to the near menu
@keveleigh keveleigh linked an issue Oct 10, 2022 that may be closed by this pull request
@jasonhbartlett
Copy link

Hi @Zee2
I'm sorry if this isn't the best spot to post about this. I am using your awesome VirtualizedScrollRectList (borrowed from the MRTKDeveTemplate project and the VirtualizedScrollRectList example scene) in my project, and I really like it! It's really slick. Although I barely understand how it works. :) I wish you would make a youtube video explaining how it works.

Anyhow, a capability I wanted to add to it was that when the user clicked on one of the buttons, the Icon would show to indicate that was the button the user had selected. And obviously the icon would disappear on any other button that was previously selected.

However, this seems to be something I can't figure out. When I enable the Icon on the button, because the button is shared in the pool, when the object gets reassigned by going out and coming back into view as another button, the Icon still shows up, but it's not the right button anymore. So, it appears like it's getting enabled on multiple buttons, but I understand that it's really the same button.

I've spent several hours using different methods trying to make this work. First with an event trigger that all the buttons listen too, and then by having the Container test it's children to compare with the last button clicked. No dice.

Do you have any suggestions for how to make this work?

@keveleigh
Copy link
Contributor

CC @maluoi as well, who worked on VirtualizedScrollRectList, if I remember correctly

@jasonhbartlett
Copy link

I apologize for the misattribution. @keveleigh As it turns out, I just figured out how to make this work using a simple private string. Not sure why I was struggling so much with it yesterday. Just one of those things. Let me know if you want, I can delete that post.

@keveleigh
Copy link
Contributor

@jasonhbartlett It's all good! I just wanted to ping as many people as I thought might be able to help!
Glad to hear you were able to figure it out 🙂 no need to delete the post: I find it better to leave things like that up in case somebody else does a search or something in the future with the same (or a similar) issue!

@AMollis AMollis assigned srinjoym and unassigned Zee2 Mar 2, 2023
@AMollis AMollis added the Release Blocker Things we must address before the next release. label Mar 2, 2023
@AMollis AMollis removed the Release Blocker Things we must address before the next release. label Apr 21, 2023
@AMollis AMollis modified the milestones: MRTK v3.0 GA, MRTK v3.0 GA+ Jun 15, 2023
@Valink
Copy link

Valink commented Jun 20, 2023

Hello :), any news on this awesome feature ?

@AMollis
Copy link
Member

AMollis commented Jun 27, 2023

This was completed with the following

@AMollis AMollis closed this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Graduation Label tracking graduating features from experimental MRTK3 UX Controls - Scroll View
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MRTK3: Scrolling Views do not work with user input.
6 participants