Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locl features that swap 2 glyphs for 1 glyph #412

Closed
aaronbell opened this issue Feb 14, 2021 · 0 comments · Fixed by #410
Closed

locl features that swap 2 glyphs for 1 glyph #412

aaronbell opened this issue Feb 14, 2021 · 0 comments · Fixed by #410

Comments

@aaronbell
Copy link
Collaborator

aaronbell commented Feb 14, 2021

Opening a bug here for me to remember.

In the Dutch locl feature, there are substitutions to access ijacute forms:

sub iacute j by iacute_j.loclNLD;
sub Iacute J by Iacute_J.loclNLD;

Generally it is not ideal to substitute two user-entered glyphs for a single glyph in a monospace coding environment. A better implementation here is: sub iacute j' by jacute. This will mean removal of the loclNLD glyph mentioned above, and addition of jacute.

In Catalan there are substitutions to access the Ŀ and ŀ:

sub  l' periodcentered' l by ldot;
sub  L' periodcentered' L by Ldot;

While this is a standard way to access the Ŀ and ŀ, I think that in this case it would make more sense to remove these substitutions and just leave the glyphs to look like l·l. These are atomic characters which can be accessed directly.

DHowett pushed a commit that referenced this issue Feb 25, 2021
A small set of fixes that resolves a couple of new bugs introduced in the latest version, plus other fixes I have been working on. 

## PR Checklist
* [x] Closes #406 - updated anchor type to lock with the other equals-related ligatures
* [x] Closes #408 - corrected component used for glyph to align with Unicode
* [x] Closes #412 - updated locl features removing iacute_j ligature and Catalan substitution
* [x] Closes #414 - increased overlaps of middle glyph for arrow ligatures
* [x] Closes #415 - reduces width of macronbelow
* [x] Closes #416 - rolls back name ID 4 modification as JetBrains cannot process it correctly
* [x] Closes #428 - rolls back variation of the underline to prevent MVAR table generation

## Detailed Description of the Pull Request / Additional comments

Full changelist:
- Repositioned tilde in related ligatures. Previously it was higher than the standard one.
- Added missing vietnamese anchors on acute and grave (futureproofing). 
- Corrected / made consistent greater & less positioning in </> and <$> related ligatures.
- Otherwise reviewed hinting
DHowett added a commit to microsoft/terminal that referenced this issue Feb 25, 2021
This update fixes some issues in Cascadia Code's February update:

microsoft/cascadia-code#406 - updated anchor type to lock with the other equals-related ligatures
microsoft/cascadia-code#408 - corrected component used for glyph to align with Unicode
microsoft/cascadia-code#412 - updated locl features removing iacute_j ligature and Catalan substitution
microsoft/cascadia-code#414 - increased overlaps of middle glyph for arrow ligatures
microsoft/cascadia-code#415 - reduces width of macronbelow
microsoft/cascadia-code#416 - rolls back name ID 4 modification as JetBrains cannot process it correctly
microsoft/cascadia-code#428 - rolls back variation of the underline to prevent MVAR table generation

Full changelist:
* Repositioned tilde in related ligatures. Previously it was higher than the standard one.
* Added missing vietnamese anchors on acute and grave (futureproofing).
* Corrected / made consistent greater & less positioning in </> and <$> related ligatures.
* Otherwise reviewed hinting
DHowett added a commit to microsoft/terminal that referenced this issue Feb 25, 2021
This update fixes some issues in Cascadia Code's February update:

microsoft/cascadia-code#406 - updated anchor type to lock with the other equals-related ligatures
microsoft/cascadia-code#408 - corrected component used for glyph to align with Unicode
microsoft/cascadia-code#412 - updated locl features removing iacute_j ligature and Catalan substitution
microsoft/cascadia-code#414 - increased overlaps of middle glyph for arrow ligatures
microsoft/cascadia-code#415 - reduces width of macronbelow
microsoft/cascadia-code#416 - rolls back name ID 4 modification as JetBrains cannot process it correctly
microsoft/cascadia-code#428 - rolls back variation of the underline to prevent MVAR table generation

Full changelist:
* Repositioned tilde in related ligatures. Previously it was higher than the standard one.
* Added missing vietnamese anchors on acute and grave (futureproofing).
* Corrected / made consistent greater & less positioning in </> and <$> related ligatures.
* Otherwise reviewed hinting
DHowett added a commit to microsoft/terminal that referenced this issue Feb 25, 2021
This update fixes some issues in Cascadia Code's February update:

microsoft/cascadia-code#406 - updated anchor type to lock with the other equals-related ligatures
microsoft/cascadia-code#408 - corrected component used for glyph to align with Unicode
microsoft/cascadia-code#412 - updated locl features removing iacute_j ligature and Catalan substitution
microsoft/cascadia-code#414 - increased overlaps of middle glyph for arrow ligatures
microsoft/cascadia-code#415 - reduces width of macronbelow
microsoft/cascadia-code#416 - rolls back name ID 4 modification as JetBrains cannot process it correctly
microsoft/cascadia-code#428 - rolls back variation of the underline to prevent MVAR table generation

Full changelist:
* Repositioned tilde in related ligatures. Previously it was higher than the standard one.
* Added missing vietnamese anchors on acute and grave (futureproofing).
* Corrected / made consistent greater & less positioning in </> and <$> related ligatures.
* Otherwise reviewed hinting

(cherry picked from commit cb03b97)
DHowett added a commit to microsoft/terminal that referenced this issue Feb 25, 2021
This update fixes some issues in Cascadia Code's February update:

microsoft/cascadia-code#406 - updated anchor type to lock with the other equals-related ligatures
microsoft/cascadia-code#408 - corrected component used for glyph to align with Unicode
microsoft/cascadia-code#412 - updated locl features removing iacute_j ligature and Catalan substitution
microsoft/cascadia-code#414 - increased overlaps of middle glyph for arrow ligatures
microsoft/cascadia-code#415 - reduces width of macronbelow
microsoft/cascadia-code#416 - rolls back name ID 4 modification as JetBrains cannot process it correctly
microsoft/cascadia-code#428 - rolls back variation of the underline to prevent MVAR table generation

Full changelist:
* Repositioned tilde in related ligatures. Previously it was higher than the standard one.
* Added missing vietnamese anchors on acute and grave (futureproofing).
* Corrected / made consistent greater & less positioning in </> and <$> related ligatures.
* Otherwise reviewed hinting

(cherry picked from commit cb03b97)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant