Fix NF Mono glyph selection, NF variants STAT, PL rclt table #721
Conversation
| @@ -111,7 +111,7 @@ def step_set_feature_file(path: Path, name: str, instance: ufoLib2.Font) -> None | |||
| for item in featureList: | |||
| if "PL" in name and item == "rclt": | |||
| featureSet += Path(path / str("rclt_PL.fea")).read_text() | |||
| if "NF" in name and item == "rclt": | |||
| elif "NF" in name and item == "rclt": | |||
There was a problem hiding this comment.
This may have caused issues with the later else, resulting in the inclusion of rclt.fea after we'd already included rclt_PL.fea in the PL variant.
|
I also figured out why the stypo variants were being ignored in the PL/NF builds; /cc @PhMajerus for the last commit |
DHowett
changed the title
|
(Thanks so much for your investigation!!) |
|
Hey, I love working on this stuff :D |
|
Let me know if there is anything I need to do on my side when adding glyphs with stypo variants. |
|
Just make sure it ends up in |
The build issue I was running into was caused by the logic that chooses when to merge Powerline glyphs into the final set before building.
It covered the following conditions:
However, it missed one:
I've simplified the logic so that we don't make this mistake again. All non-Cascadia-Code variants will have their names overridden, and if they contain PL or NF they will get special treatment.
I've also added the NF variants to the STAT table table and fixed the generation of rclt for PL variants.