Don't disable existing logger when initializing qlib. #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @you-n-g , could you help review this PR? This could help qlib work with other packages. |
you-n-g
reviewed
Nov 7, 2022
|
LGTM. |
qianyun210603
pushed a commit
to qianyun210603/qlib
that referenced
this pull request
Mar 23, 2023
* Don't disable existing logger when initializing qlib. * Add comma in the end of the config line. * Add comment to the added config. Co-authored-by: Jinge Wang <jingewang@microsoft.com>
qianyun210603
pushed a commit
to qianyun210603/qlib
that referenced
this pull request
Mar 23, 2023
* Don't disable existing logger when initializing qlib. * Add comma in the end of the config line. * Add comment to the added config. Co-authored-by: Jinge Wang <jingewang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add following config line to logging_config to prevent disabling the existing logger.
Without this line, loggers from other code will be disabled.
Motivation and Context
When using qlib with other services and apps, loggers from other services will be disabled after qlib initialization. This is not friendly to collaborate with other packages.
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Screenshots of Test Results (if appropriate):
Types of changes