-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed log_param error #1362
Fixed log_param error #1362
Conversation
qlib/workflow/recorder.py
Outdated
@@ -422,7 +423,7 @@ def load_object(self, name, unpickler=pickle.Unpickler): | |||
|
|||
path = None | |||
try: | |||
path = self.client.download_artifacts(self.id, name) | |||
path = mlflow.artifacts.download_artifacts(run_id=self.id, artifact_path=name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the related issue to this PR?
I didn't get the necessity of this change.
@@ -21,6 +21,7 @@ | |||
from mlflow.store.artifact.azure_blob_artifact_repo import AzureBlobArtifactRepository | |||
|
|||
logger = get_module_logger("workflow", logging.INFO) | |||
mlflow.utils.validation.MAX_PARAM_VAL_LENGTH = 1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for?
@SunsetWolf I think |
Resolved |
@SunsetWolf It looks great now. |
* fix_qrun_error * add_description
* fix_qrun_error * add_description
* fix_qrun_error * add_description
Description
Motivation and Context
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.py
under upper directory ofqlib
.Screenshots of Test Results (if appropriate):
Types of changes