Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated syntax in numpy #1507

Merged
merged 2 commits into from
May 8, 2023
Merged

Conversation

Chaoyingz
Copy link
Contributor

Description

See #1506 .

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
    image

  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@github-actions github-actions bot added the waiting for triage Cannot auto-triage, wait for triage. label May 5, 2023
@Fivele-Li
Copy link
Contributor

Hi, could you please modify the other places in the project together where np.str and np.bool are used? we'd really appreciate it!

@Chaoyingz
Copy link
Contributor Author

No problem, I'll make the changes.

@Fivele-Li Fivele-Li added maintenance improving code readability and maintainability and removed waiting for triage Cannot auto-triage, wait for triage. labels May 6, 2023
@you-n-g you-n-g merged commit 37a59f2 into microsoft:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance improving code readability and maintainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants