Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[931] Remove mutable default argument. #932

Merged
merged 1 commit into from
Feb 28, 2022
Merged

[931] Remove mutable default argument. #932

merged 1 commit into from
Feb 28, 2022

Conversation

ChiahungTai
Copy link
Collaborator

Description

Fix #931 .

Motivation and Context

How Has This Been Tested?

<! --- Put an x in all the boxes that apply: --->

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@you-n-g
Copy link
Collaborator

you-n-g commented Feb 28, 2022

It looks great! Thanks so much!

@you-n-g you-n-g merged commit 4dc6693 into microsoft:main Feb 28, 2022
@ChiahungTai ChiahungTai deleted the 931 branch March 1, 2022 12:03
@you-n-g you-n-g added the enhancement New feature or request label Mar 8, 2022
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
@ChiahungTai
[931] Remove mutable default argument. (microsoft#932)
f68c4b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Refactor] Non mutable default argument.
2 participants
@ChiahungTai @you-n-g