Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong error messages. #946

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Fix wrong error messages. #946

merged 1 commit into from
Mar 3, 2022

Conversation

ChiahungTai
Copy link
Collaborator

Description

Motivation and Context

Fix wrong NotImplementedError message.
Looks like it is a copy-paste bug.

How Has This Been Tested?

<! --- Put an x in all the boxes that apply: --->

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.
    N/A

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@you-n-g
Copy link
Collaborator

you-n-g commented Mar 3, 2022

Thanks so much!

@you-n-g you-n-g merged commit ea4fb33 into microsoft:main Mar 3, 2022
@ChiahungTai ChiahungTai deleted the wrong_msg branch March 4, 2022 01:22
@you-n-g you-n-g added the enhancement New feature or request label Mar 8, 2022
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
@ChiahungTai
Fix wrong error messages. (microsoft#946)
a866b56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChiahungTai @you-n-g