Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[949] - Remove argument internal in BaseRun::download_data. #953

Merged
merged 3 commits into from
Mar 8, 2022
Merged

[949] - Remove argument internal in BaseRun::download_data. #953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ef76eb
[949] - Remove argument internal in BaseRun::download_data.
ChiahungTai Mar 7, 2022
777bd1f
Fix black.
ChiahungTai Mar 7, 2022
72b0f03
Fix bug.
ChiahungTai Mar 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions scripts/data_collector/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,6 @@ def download_data(
delay=0,
start=None,
end=None,
interval="1d",
check_data_length: int = None,
limit_nums=None,
):
Expand Down Expand Up @@ -396,7 +395,7 @@ def download_data(
delay=delay,
start=start,
end=end,
interval=interval,
interval=self.interval,
check_data_length=check_data_length,
limit_nums=limit_nums,
).collector_data()
Expand Down
3 changes: 1 addition & 2 deletions scripts/data_collector/crypto/collector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,6 @@ def download_data(
delay=0,
start=None,
end=None,
interval="1d",
check_data_length: int = None,
limit_nums=None,
):
Expand Down Expand Up @@ -255,7 +254,7 @@ def download_data(
$ python collector.py download_data --source_dir ~/.qlib/crypto_data/source/1d --start 2015-01-01 --end 2021-11-30 --delay 1 --interval 1d
"""

super(Run, self).download_data(max_collector_count, delay, start, end, interval, check_data_length, limit_nums)
super(Run, self).download_data(max_collector_count, delay, start, end, check_data_length, limit_nums)

def normalize_data(self, date_field_name: str = "date", symbol_field_name: str = "symbol"):
"""normalize data
Expand Down
3 changes: 1 addition & 2 deletions scripts/data_collector/fund/collector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,6 @@ def download_data(
delay=0,
start=None,
end=None,
interval="1d",
check_data_length: int = None,
limit_nums=None,
):
Expand Down Expand Up @@ -282,7 +281,7 @@ def download_data(
$ python collector.py download_data --source_dir ~/.qlib/fund_data/source/cn_data --region CN --start 2020-11-01 --end 2020-11-10 --delay 0.1 --interval 1d
"""

super(Run, self).download_data(max_collector_count, delay, start, end, interval, check_data_length, limit_nums)
super(Run, self).download_data(max_collector_count, delay, start, end, check_data_length, limit_nums)

def normalize_data(self, date_field_name: str = "date", symbol_field_name: str = "symbol"):
"""normalize data
Expand Down
4 changes: 1 addition & 3 deletions scripts/data_collector/yahoo/collector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,9 +900,7 @@ def download_data(
# get 1m data
$ python collector.py download_data --source_dir ~/.qlib/stock_data/source --region CN --start 2020-11-01 --end 2020-11-10 --delay 0.1 --interval 1m
"""
super(Run, self).download_data(
max_collector_count, delay, start, end, self.interval, check_data_length, limit_nums
)
super(Run, self).download_data(max_collector_count, delay, start, end, check_data_length, limit_nums)

def normalize_data(
self,
Expand Down