Skip to content

Commit

Permalink
Remove jest and jest-junit from runtime dependencies (facebook#23276)
Browse files Browse the repository at this point in the history
Summary:
Commit 06c13b3 pretend to update jest
to new version, but also adds jest and jest-junit to runtime dependencies
list (in addition to dev dependencies).

This commit fixes this, by removing jest and jest-junit from runtime
dependeincies.

As for motivation... story is short:
1. Updating RN 0.58.1 -> 0.58.3 I found that whole babel@6 infrastructure was returned to my `node_modules` (it is dangerous, because many tools like metro can found it and use it instead of babel@7).
2. It was because of this commit: 9d19ab0 that have 130 random files changed (and provides no meaning description).
But it points to: b864e7e (which also provides no meaning description, why it was reverted?)
And finally points to: 696bd89, which was a "sync with master" commit. Ok. So it was from master.
3. Then I checked that jest still in runtime dependencies on master and fixed that. Also I hope this will be cherry picked into 0.58-stable.

[General] [Fixed] - Fix jest and jest-junit to be only development dependencies
Pull Request resolved: facebook#23276

Differential Revision: D13941275

Pulled By: cpojer

fbshipit-source-id: a6f3377e670554b21f3ebd2f12d33e29d2969df1
  • Loading branch information
vovkasm authored and grabbou committed Feb 4, 2019
1 parent b403e77 commit 8ac42cb
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,6 @@
"glob": "^7.1.1",
"graceful-fs": "^4.1.3",
"inquirer": "^3.0.6",
"jest": "24.0.0-alpha.6",
"jest-junit": "5.2.0",
"lodash": "^4.17.5",
"metro": "^0.49.1",
"metro-babel-register": "^0.49.1",
Expand Down Expand Up @@ -249,4 +247,4 @@
}
}
}
}
}

0 comments on commit 8ac42cb

Please sign in to comment.