Skip to content

Commit

Permalink
Insert optional data visitor file regions cache (#2544)
Browse files Browse the repository at this point in the history
* Allow per-instance file regions cache to be set on InsertOptionalDataVisitor.

* Provide context region construction helper in 'FileRegionsCache'.
  • Loading branch information
michaelcfanning authored Sep 12, 2022
1 parent eb24e66 commit af69a18
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/ReleaseHistory.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# SARIF Package Release History (SDK, Driver, Converters, and Multitool)

## Unreleased
* FEATURE: Allow initialization of file regions cache in `InsertOptionalDataVisitor` (previously initialized exclusively from `FileRegionsCache.Instance`).
* BUGFIX: Resolve issue where `match-results-forward` command fails to generate VersionControlDetails data. [#2487](https://github.com/microsoft/sarif-sdk/pull/2487)
* BUGFIX: Remove duplicated rule definitions when executing `match-results-forward` commands for results with sub-rule ids. [#2486](https://github.com/microsoft/sarif-sdk/pull/2486)
Expand Down
2 changes: 1 addition & 1 deletion src/Sarif/FileRegionsCache.cs
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ private Region PopulateTextRegionProperties(NewLineIndex lineIndex, Region input
return region;
}

internal Region ConstructMultilineContextSnippet(Region inputRegion, Uri uri)
public Region ConstructMultilineContextSnippet(Region inputRegion, Uri uri)
{
if (inputRegion?.IsBinaryRegion != false)
{
Expand Down

0 comments on commit af69a18

Please sign in to comment.