[catch2] Set CMAKE_CXX_STANDARD to 17. #25019
Conversation
microsoft#24762 (comment) indicates that building for C++17 will include extra catch2 formatters for types like std::string_view, so we should build catch2 with that version selected.
BillyONeal
added
category:port-bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| fix-install-path.patch | ||
| ) | ||
|
|
||
| vcpkg_cmake_configure( | ||
| SOURCE_PATH "${SOURCE_PATH}" | ||
| OPTIONS | ||
| -DCATCH_INSTALL_DOCS=OFF | ||
| -DCMAKE_CXX_STANDARD=17 |
There was a problem hiding this comment.
This is a toolchain setting not a port setting.....
There was a problem hiding this comment.
I disagree that it's a toolchain setting in general since it usually isn't ABI affecting. There's no reason everything in the tree needs to agree on the same answer.
There was a problem hiding this comment.
@BillyONeal, should we add a feature to catch2 instead? like abseil, https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/maintainer-guide.md#a-feature-may-replace-polyfills-with-aliases-provided-that-replacement-is-baked-into-the-installed-tree
There was a problem hiding this comment.
@PhoebeHui No: abseil's feature controls whether it provides a polyfill. That is, absl::string_view will be std::string_view or absl::string_view depending on that feature. In contrast, this merely enables or disables functionality: it allows CHECK(some_string_view == "a literal") to compile and link.
There was a problem hiding this comment.
I see, thanks for your clarification.
Vcpkg problem has since been fixed upstream, cf. microsoft/vcpkg#25019 .
#24762 (comment) indicates that building for C++17 will include extra catch2 formatters for types like std::string_view, so we should build catch2 with that version selected.