Skip to content

Commit

Permalink
Remove disposing of editor input in override service
Browse files Browse the repository at this point in the history
  • Loading branch information
lramos15 committed May 18, 2021
1 parent 2a9f023 commit a069768
Showing 1 changed file with 1 addition and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,7 @@ export class EditorOverrideService extends Disposable implements IEditorOverride
// Wait one second to give the user ample time to see the current editor then ask them to configure a default
this.doHandleConflictingDefaults(selectedContribution.editorInfo.label, input.editor, input.options ?? options, group);
}
// Dispose of the passed in editor as we will return a new one
if (!input?.editor.matches(editor)) {
editor.dispose();
}

// Add the group as we might've changed it with the quickpick
if (input) {
this.sendOverrideTelemetry(input.editor);
Expand Down

0 comments on commit a069768

Please sign in to comment.