Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorize in debug console for evaluation results #35324

Closed
roblourens opened this issue Sep 28, 2017 · 3 comments
Closed

Colorize in debug console for evaluation results #35324

roblourens opened this issue Sep 28, 2017 · 3 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality release-notes Release notes issues verified Verification succeeded
Milestone

Comments

@roblourens
Copy link
Member

From #34043

It would be nice to keep colorization for 'evaluate' requests, since the result has a 'type'. node2 doesn't set the type... it could though.

image

vs previously

image

@roblourens roblourens added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Sep 28, 2017
@isidorn
Copy link
Contributor

isidorn commented Sep 29, 2017

We could do this for october.
@roblourens Can you please ping me when node2 introduces a type so I look into implementing this on the vscode side. Thanks

@isidorn
Copy link
Contributor

isidorn commented Oct 9, 2017

I have pushed some support for this, preciesely:

  • For evaluate expressions I always try to colorise
  • If a type is "boolean", "string" or "number" I just use that type, otherwise I try to guess as before

I did it in this way such that C# does not get broken if they return "int" instead of "number".

Coloring is still disabled for simple output in repl.
In practice this has behaved the best for me, but I am open for suggestions on how to more fine tune this.
@roblourens still has to pick this up for node2 however there is already an open issue for this thus I am closing this one.
fyi @weinand

@isidorn isidorn closed this as completed Oct 9, 2017
roblourens added a commit to microsoft/vscode-chrome-debug-core that referenced this issue Oct 27, 2017
roblourens added a commit to microsoft/vscode-chrome-debug-core that referenced this issue Oct 27, 2017
@roblourens roblourens added the verification-needed Verification of issue is requested label Oct 30, 2017
@roblourens
Copy link
Member Author

Verifier - debug with inspector and verify that primitive values returned from evaluating things in the debug console are colored appropriately, as in the above screenshot.

@mjbvz mjbvz added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Oct 31, 2017
@isidorn isidorn added the release-notes Release notes issues label Nov 3, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality release-notes Release notes issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants