Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #126178 (Recovery) #126293

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Fix #126178 (Recovery) #126293

merged 1 commit into from
Jun 14, 2021

Conversation

andreamah
Copy link
Contributor

Previously, opening two markdown files side-by-side caused unexpected scrolling. This was due to a bug introduced in #123727, which was fixed by separating the last scroll locations of static/text editors and consuming the info entry upon access.

Tested with the following configurations:

  • same markdown file in both columns.
  • two different markdown files in separate columns.
  • an untitled markdown-formatted file in two columns.
  • two different untitled markdown-formatted files in separate columns.

This PR fixes #126178

@andreamah andreamah added this to the June 2021 milestone Jun 14, 2021
@andreamah andreamah requested a review from mjbvz June 14, 2021 20:48
@andreamah andreamah self-assigned this Jun 14, 2021
@andreamah andreamah mentioned this pull request Jun 14, 2021
Merged
mjbvz
mjbvz approved these changes Jun 14, 2021
View reviewed changes
Copy link
Collaborator

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good for the recovery. You can merge you are confident from testing

@andreamah andreamah changed the title Fix #126178 Fix #126178 (Recovery) Jun 14, 2021
@andreamah andreamah mentioned this pull request Jun 14, 2021
Closed
@andreamah andreamah merged commit 20a512d into release/1.57 Jun 14, 2021
@andreamah andreamah deleted the dev/andreamah/readme-scrolling-bugfix branch June 14, 2021 22:10
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mjbvz mjbvz mjbvz approved these changes

Assignees

@andreamah andreamah

Labels
None yet
Projects
None yet
Milestone
June 2021
Development

Successfully merging this pull request may close these issues.
2 participants
@andreamah @mjbvz