Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve settings for ag #186

Closed
wants to merge 1 commit into from
Closed

Improve settings for ag #186

wants to merge 1 commit into from

Conversation

DSIW
Copy link

@DSIW DSIW commented Jul 5, 2016

The maintainer of deprecated ag.vim recommends to use these settings: rking#124 (comment)

@ches
Copy link
Collaborator

ches commented Jul 5, 2016

Hi, thanks for the suggestion.

I know this seems innocuous, but giving it some thought, I'd rather not recommend these abbreviations. Initially, there are these things I would have suggested:

  • --smart-case is on by default, so it's redundant.
  • The abbreviations for aG and AG are cruft to me. If people want them because they fat-finger them all the time, fine, but they can add their own based on one good example.
  • Lowercase commands are core Vim's namespace. Users can make their own choice to set an :ag abbreviation, but I'm not going to recommend it.

So these things are surmountable, you could leave them out. But the bigger problem is that this is incomplete. There are :AckFile, :AckWindow, :AckAdd, :AckFromSearch, and more. Plus there are :LAck versions of most of these. Listing abbreviations for everything seems silly, maintaining the list in documentation tracked in the repo is busywork for me, and actually including them in the plugin code would be even worse in that regard.

I think the ideal place for these would probably be to create a "Migrating from ag.vim" page on the GitHub wiki for the project. I'll have to ask @mileszs to configure the wiki to be user-editable—in the meantime if anyone would like to comment here on this issue with a full listing of abbreviations for those migrating (back), I'll create the wiki page for you.

@DSIW
Copy link
Author

DSIW commented Jul 5, 2016

I understand, thanks for your great response.

@DSIW DSIW closed this Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants