-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore]: clean dependencies #1287
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1287 +/- ##
=======================================
Coverage 95.78% 95.78%
=======================================
Files 154 154
Lines 6903 6903
=======================================
Hits 6612 6612
Misses 291 291
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why it passed the tests but there is an incompatibility between some packages:
...
#11 137.0 ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
#11 137.0 cleo 2.0.1 requires rapidfuzz<3.0.0,>=2.2.0, but you have rapidfuzz 3.2.0 which is incompatible.
...
See Build & run docker
steps
Yeah i saw this also but it runs locally inside docker also without issues ... i think we override repidfuzz with our >=3.0.0 version and it seems not to break anything inside cleo or there is no use of it |
@odulcy-mindee checked again it overrides it: rapidfuzz-3.2.0 is installed and all works 😅 |
cleo lib ref: python-poetry/cleo@57c6b9e (as i wrote on LinkedIn ^^) |
This PR: