Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: clean dependencies #1287

Merged
merged 3 commits into from
Aug 28, 2023
Merged

[chore]: clean dependencies #1287

merged 3 commits into from
Aug 28, 2023

Conversation

felixT2K
Copy link
Contributor

@felixT2K felixT2K commented Aug 25, 2023

This PR:

  • updates API dependencies
  • remove upper bounds for dev dependencies
  • increase minimum tf2onnx version to fix the incompatibility with >tf2.12

@felixT2K felixT2K marked this pull request as draft August 25, 2023 11:59
@felixdittrich92 felixdittrich92 added this to the 0.7.0 milestone Aug 25, 2023
@felixdittrich92 felixdittrich92 added topic: build Related to dependencies and build ext: api Related to api folder type: misc Miscellaneous labels Aug 25, 2023
@felixdittrich92 felixdittrich92 self-assigned this Aug 25, 2023
@felixT2K felixT2K marked this pull request as ready for review August 25, 2023 12:23
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #1287 (21a4972) into main (3deac68) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1287   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files         154      154           
  Lines        6903     6903           
=======================================
  Hits         6612     6612           
  Misses        291      291           
Flag Coverage Δ
unittests 95.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@odulcy-mindee odulcy-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why it passed the tests but there is an incompatibility between some packages:

...
#11 137.0 ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
#11 137.0 cleo 2.0.1 requires rapidfuzz<3.0.0,>=2.2.0, but you have rapidfuzz 3.2.0 which is incompatible.
...

See Build & run docker steps

@felixT2K
Copy link
Contributor Author

I don't know why it passed the tests but there is an incompatibility between some packages:

...
#11 137.0 ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
#11 137.0 cleo 2.0.1 requires rapidfuzz<3.0.0,>=2.2.0, but you have rapidfuzz 3.2.0 which is incompatible.
...

See Build & run docker steps

Yeah i saw this also but it runs locally inside docker also without issues ... i think we override repidfuzz with our >=3.0.0 version and it seems not to break anything inside cleo or there is no use of it

@felixT2K
Copy link
Contributor Author

@odulcy-mindee checked again it overrides it: rapidfuzz-3.2.0 is installed and all works 😅

@felixT2K
Copy link
Contributor Author

cleo lib ref: python-poetry/cleo@57c6b9e (as i wrote on LinkedIn ^^)

@felixdittrich92 felixdittrich92 merged commit e937217 into mindee:main Aug 28, 2023
58 checks passed
@felixT2K felixT2K deleted the deps branch August 28, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: api Related to api folder topic: build Related to dependencies and build type: misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants