Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the way model is saved in ddp #1289

Merged
merged 9 commits into from
Aug 27, 2023
Merged

Conversation

@felixdittrich92
Copy link
Contributor

Hi @venkatapathy 👋

Thanks for opening this 👍
Could you please remove the .gitignore changes ?

@venkatapathy
Copy link
Contributor Author

I have deleted the .gitignore. Can you please check now? Thanks

@felixdittrich92
Copy link
Contributor

felixdittrich92 commented Aug 26, 2023

@venkatapathy you have deleted the whole File please delete only the two lines you have added

Copy link
Contributor Author

@venkatapathy venkatapathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this is fine?

@felixdittrich92
Copy link
Contributor

@venkatapathy please restore the last line in .gitignore see: https://github.com/mindee/doctr/pull/1289/files
than it's fine 👍

@venkatapathy
Copy link
Contributor Author

thanks. i have done it :)

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Merging #1289 (c9eb5ae) into main (3deac68) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1289      +/-   ##
==========================================
- Coverage   95.78%   95.76%   -0.02%     
==========================================
  Files         154      154              
  Lines        6903     6903              
==========================================
- Hits         6612     6611       -1     
- Misses        291      292       +1     
Flag Coverage Δ
unittests 95.76% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Contributor

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 👍

@felixdittrich92 felixdittrich92 added this to the 0.7.0 milestone Aug 27, 2023
@felixdittrich92 felixdittrich92 added type: bug Something isn't working ext: references Related to references folder framework: pytorch Related to PyTorch backend topic: text recognition Related to the task of text recognition labels Aug 27, 2023
@felixdittrich92 felixdittrich92 self-assigned this Aug 27, 2023
@felixdittrich92 felixdittrich92 merged commit 69dffa3 into mindee:main Aug 27, 2023
57 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references Related to references folder framework: pytorch Related to PyTorch backend topic: text recognition Related to the task of text recognition type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants