-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Pin py3.11 for MacOS latest / update publish version checks #1503
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1503 +/- ##
==========================================
- Coverage 96.28% 96.25% -0.04%
==========================================
Files 163 163
Lines 7706 7707 +1
==========================================
- Hits 7420 7418 -2
- Misses 286 289 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@odulcy-mindee We could apply this as temp fix because i think the fix in setup-python takes longer as expected :) Maybe i will write some points in the repo wiki we should keep in mind --> https://github.com/mindee/doctr/wiki/TODO%E2%80%90Points |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about pin macos version to macos-13
instead, as suggested here ?
actions/setup-python#855
@odulcy-mindee In this case we would need to update the required CI jobs The repo says for python:
So i expect a fix for this in a future release that we can easily change this back, without updating our required CI jobs. That's also the reason why i would prefer the py3.11 pin over the maco-13 pin :) |
Aaaaaah, that's true :-( Ok, let's keep it like that |
MacOS:
actions/setup-python#855
actions/setup-python#865