Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added page selection & JSON display to demo #369

Merged
merged 6 commits into from
Jul 8, 2021
Merged

Conversation

fg-mindee
Copy link
Contributor

@fg-mindee fg-mindee commented Jul 7, 2021

This PR introduces the following modifications:

  • added tip to enlarge images
  • switched to 4 columns display
  • added page selection (for multi-page PDF)
  • speeded up analysis by only analyzing the selected page
  • added JSON output display (foldable, and can be copied to clipboard)
  • updated demo display in README

Here is how it renders:
Demo

Closes #234

Any feedback is welcome!

@fg-mindee fg-mindee added topic: documentation Improvements or additions to documentation type: enhancement Improvement ext: demo Related to demo folder labels Jul 7, 2021
@fg-mindee fg-mindee added this to the 0.4.0 milestone Jul 7, 2021
@fg-mindee fg-mindee self-assigned this Jul 7, 2021
@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #369 (a46c527) into main (c18025b) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
- Coverage   96.18%   96.15%   -0.03%     
==========================================
  Files          83       83              
  Lines        3461     3461              
==========================================
- Hits         3329     3328       -1     
- Misses        132      133       +1     
Flag Coverage Δ
unittests 96.15% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dels/detection/differentiable_binarization/base.py 91.30% <0.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c18025b...a46c527. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tuning

@fg-mindee fg-mindee merged commit 5e7f65d into main Jul 8, 2021
@fg-mindee fg-mindee deleted the demo-update branch July 8, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: demo Related to demo folder topic: documentation Improvements or additions to documentation type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[demo] Improve UI for OCR result display
2 participants