Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LR scheduler's final LR in TF scripts #397

Merged
merged 8 commits into from
Aug 5, 2021
Merged

fix: LR scheduler's final LR in TF scripts #397

merged 8 commits into from
Aug 5, 2021

Conversation

charlesmindee
Copy link
Collaborator

This PR updates the lr scheduler in tf scripts to have the same training parameters in both tensorflow and pytorch scripts. The changes were already made locally on the training machine before launching trainings, nothing to worry about.

@charlesmindee charlesmindee self-assigned this Aug 5, 2021
@charlesmindee charlesmindee added ext: references Related to references folder framework: tensorflow Related to TensorFlow backend labels Aug 5, 2021
@charlesmindee charlesmindee added this to the 0.3.1 milestone Aug 5, 2021
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #397 (fbef2e5) into main (0359ecc) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
+ Coverage   95.85%   95.87%   +0.02%     
==========================================
  Files          91       91              
  Lines        3761     3761              
==========================================
+ Hits         3605     3606       +1     
+ Misses        156      155       -1     
Flag Coverage Δ
unittests 95.87% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dels/detection/differentiable_binarization/base.py 91.97% <0.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0359ecc...fbef2e5. Read the comment docs.

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charlesmindee charlesmindee merged commit 29c4c65 into main Aug 5, 2021
@charlesmindee charlesmindee deleted the mis branch August 5, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references Related to references folder framework: tensorflow Related to TensorFlow backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants