Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hugging Face demo shield #501

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Add Hugging Face demo shield #501

merged 1 commit into from
Sep 29, 2021

Conversation

osanseviero
Copy link
Contributor

As suggested in #492 (comment)

@fg-mindee fg-mindee self-requested a review September 29, 2021 10:40
@fg-mindee fg-mindee self-assigned this Sep 29, 2021
@fg-mindee fg-mindee added topic: documentation Improvements or additions to documentation ext: demo Related to demo folder labels Sep 29, 2021
@fg-mindee fg-mindee added this to the 0.4.1 milestone Sep 29, 2021
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Omar 🙏

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #501 (93c9595) into main (3b2d375) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   51.09%   51.07%   -0.03%     
==========================================
  Files         109      109              
  Lines        4188     4188              
==========================================
- Hits         2140     2139       -1     
- Misses       2048     2049       +1     
Flag Coverage Δ
unittests 51.07% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/_utils.py 28.57% <0.00%> (-1.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b2d375...93c9595. Read the comment docs.

@fg-mindee fg-mindee merged commit 54b6ec4 into mindee:main Sep 29, 2021
@fg-mindee
Copy link
Contributor

Hi @osanseviero 👋

Following up on #543, the demo deployed on HF Spaces is failing and should be updated 😅
Is there a way to add me as a contributor so that you don't have to do those updates yourself on HF Spaces?

Best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: demo Related to demo folder topic: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants