Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixed docstrings of datasets #603

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Conversation

felixdittrich92
Copy link
Contributor

adding blank line between docstring and constructor (format)
and fix two wrong docstrings / docu

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #603 (cd75b5e) into main (d117ea7) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
+ Coverage   96.03%   96.06%   +0.02%     
==========================================
  Files         110      110              
  Lines        4265     4265              
==========================================
+ Hits         4096     4097       +1     
+ Misses        169      168       -1     
Flag Coverage Δ
unittests 96.06% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/detection.py 96.96% <ø> (ø)
doctr/datasets/recognition.py 92.00% <ø> (ø)
...dels/detection/differentiable_binarization/base.py 91.82% <0.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d117ea7...cd75b5e. Read the comment docs.

@fg-mindee fg-mindee self-requested a review November 10, 2021 15:14
@fg-mindee fg-mindee self-assigned this Nov 10, 2021
@fg-mindee fg-mindee added the module: datasets Related to doctr.datasets label Nov 10, 2021
@fg-mindee fg-mindee added this to the 0.4.1 milestone Nov 10, 2021
@fg-mindee fg-mindee added the topic: documentation Improvements or additions to documentation label Nov 10, 2021
@fg-mindee fg-mindee changed the title Fix: typo and format docs: Fixed docstrings of datasets Nov 10, 2021
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docstring fix!

@@ -30,6 +30,7 @@ class DetectionDataset(AbstractDataset):
sample_transforms: composable transformations that will be applied to each image
rotated_bbox: whether polygons should be considered as rotated bounding box (instead of straight ones)
"""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious here, why was this needed? (all style checks are passing)

>>> img, target = train_set[0]

Args:
img_folder: path to the images folder
labels_path: pathe to the json file containing all labels (character sequences)
sample_transforms: composable transformations that will be applied to each image
"""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@fg-mindee fg-mindee merged commit 2335b6f into mindee:main Nov 10, 2021
@felixdittrich92 felixdittrich92 deleted the typofix branch November 12, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: datasets Related to doctr.datasets topic: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants