Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reopening #597 SVT dataset integration #620

Merged
merged 5 commits into from
Nov 15, 2021
Merged

reopening #597 SVT dataset integration #620

merged 5 commits into from
Nov 15, 2021

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Nov 13, 2021 •
edited by fg-mindee
Loading

Adds SVT dataset

cf. #597

@codecov
Copy link

codecov bot commented Nov 13, 2021 •
edited
Loading

Codecov Report

Merging #620 (cdd76ae) into main (400aec0) will increase coverage by 0.03%.
The diff coverage is 97.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
+ Coverage   96.16%   96.19%   +0.03%     
==========================================
  Files         111      112       +1     
  Lines        4300     4335      +35     
==========================================
+ Hits         4135     4170      +35     
  Misses        165      165
Flag Coverage Δ
unittests 96.19% <97.22%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/utils/metrics.py 96.59% <ø> (ø)
doctr/datasets/svt.py 97.05% <97.05%> (ø)
doctr/datasets/__init__.py 100.00% <100.00%> (ø)
doctr/datasets/datasets/base.py 95.45% <100.00%> (ø)
...dels/detection/differentiable_binarization/base.py 91.82% <0.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34cae52...cdd76ae. Read the comment docs.

@fg-mindee fg-mindee self-requested a review November 15, 2021 11:11
@fg-mindee fg-mindee self-assigned this Nov 15, 2021
@fg-mindee fg-mindee added module: datasets Related to doctr.datasets ext: tests Related to tests folder topic: documentation Improvements or additions to documentation labels Nov 15, 2021
fg-mindee
fg-mindee suggested changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked locally and added a few suggestions!

doctr/datasets/svt.py Outdated Show resolved Hide resolved
doctr/datasets/svt.py Outdated Show resolved Hide resolved
doctr/datasets/svt.py Outdated Show resolved Hide resolved
@fg-mindee fg-mindee mentioned this pull request Nov 15, 2021
Closed
7 tasks
fg-mindee
fg-mindee approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Felix 🙏

@fg-mindee fg-mindee merged commit 1207416 into mindee:main Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fg-mindee fg-mindee fg-mindee approved these changes

Assignees

@fg-mindee fg-mindee

Labels
ext: tests Related to tests folder module: datasets Related to doctr.datasets topic: documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixdittrich92 @fg-mindee