Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support of FasterRCNN for PyTorch #691

Merged
merged 4 commits into from
Dec 10, 2021
Merged

feat: Added support of FasterRCNN for PyTorch #691

merged 4 commits into from
Dec 10, 2021

Conversation

fg-mindee
Copy link
Contributor

This PR introduces the following modifications:

  • adds fasterrcnn_mobilenet_v3_large_fpn as supported architecture for PyTorch
  • adds corresponding unittests
  • updates training script accordingly (and adding AMP support)

Any feedback is welcome!

@fg-mindee fg-mindee added module: models Related to doctr.models ext: tests Related to tests folder ext: references Related to references folder framework: pytorch Related to PyTorch backend topic: object detection Related to the task of object detection labels Dec 9, 2021
@fg-mindee fg-mindee added this to the 0.5.0 milestone Dec 9, 2021
@fg-mindee fg-mindee self-assigned this Dec 9, 2021
Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #691 (73b09ee) into main (9c45ba6) will decrease coverage by 0.45%.
The diff coverage is 95.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #691      +/-   ##
==========================================
- Coverage   96.40%   95.95%   -0.46%     
==========================================
  Files         117      120       +3     
  Lines        4540     4568      +28     
==========================================
+ Hits         4377     4383       +6     
- Misses        163      185      +22     
Flag Coverage Δ
unittests 95.95% <95.00%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/obj_detection/faster_rcnn/pytorch.py 93.75% <93.75%> (ø)
doctr/models/obj_detection/__init__.py 100.00% <100.00%> (ø)
doctr/models/obj_detection/faster_rcnn/__init__.py 100.00% <100.00%> (ø)
doctr/models/recognition/crnn/pytorch.py 94.18% <0.00%> (-5.82%) ⬇️
doctr/models/detection/linknet/base.py 83.16% <0.00%> (-3.97%) ⬇️
...dels/detection/differentiable_binarization/base.py 90.00% <0.00%> (-2.78%) ⬇️
doctr/models/builder.py 96.49% <0.00%> (-2.64%) ⬇️
doctr/models/recognition/master/pytorch.py 93.47% <0.00%> (-2.11%) ⬇️
...s/detection/differentiable_binarization/pytorch.py 97.50% <0.00%> (-0.81%) ⬇️
doctr/models/detection/linknet/pytorch.py 98.07% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c45ba6...73b09ee. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references Related to references folder ext: tests Related to tests folder framework: pytorch Related to PyTorch backend module: models Related to doctr.models topic: object detection Related to the task of object detection type: new feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants