Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imgur5k dataset integration #785

Merged
merged 57 commits into from
Jan 10, 2022
Merged

Imgur5k dataset integration #785

merged 57 commits into from
Jan 10, 2022

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Jan 5, 2022

Integrates IMGUR5K dataset

Todo:

  • rework box computations

Closes:
#587

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #785 (70f0b78) into main (e14e643) will decrease coverage by 0.02%.
The diff coverage is 92.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #785      +/-   ##
==========================================
- Coverage   96.06%   96.03%   -0.03%     
==========================================
  Files         130      131       +1     
  Lines        4901     4942      +41     
==========================================
+ Hits         4708     4746      +38     
- Misses        193      196       +3     
Flag Coverage Δ
unittests 96.03% <92.68%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/imgur5k.py 92.50% <92.50%> (ø)
doctr/datasets/__init__.py 100.00% <100.00%> (ø)
doctr/transforms/modules/base.py 94.59% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14e643...70f0b78. Read the comment docs.

@fg-mindee fg-mindee self-assigned this Jan 6, 2022
@fg-mindee fg-mindee added module: datasets Related to doctr.datasets type: new feature New feature ext: docs Related to docs folder ext: tests Related to tests folder labels Jan 6, 2022
@fg-mindee fg-mindee added this to the 0.6.0 milestone Jan 6, 2022
@fg-mindee fg-mindee modified the milestones: 0.6.0, 1.0.0 Jan 6, 2022
@felixdittrich92 felixdittrich92 changed the title [WIP] Imgur5k dataset integration Imgur5k dataset integration Jan 6, 2022
@felixdittrich92 felixdittrich92 marked this pull request as ready for review January 6, 2022 08:27
@fg-mindee fg-mindee self-requested a review January 10, 2022 11:56
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Felix!
A few improvement suggestions in the comments but the rest is good!

>>> img, target = test_set[0]
Args:
img_folder: folder with all the images of the dataset
label_path: path to the annotations file of the dataset
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing the "train" arg description

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The arg descriptions need to be in the same order as in the __init__ 🙃

doctr/datasets/imgur5k.py Outdated Show resolved Hide resolved
doctr/datasets/imgur5k.py Outdated Show resolved Hide resolved
doctr/datasets/imgur5k.py Outdated Show resolved Hide resolved
doctr/datasets/imgur5k.py Outdated Show resolved Hide resolved
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo and then we're good!

>>> img, target = test_set[0]
Args:
img_folder: folder with all the images of the dataset
label_path: path to the annotations file of the dataset
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The arg descriptions need to be in the same order as in the __init__ 🙃

@fg-mindee fg-mindee linked an issue Jan 10, 2022 that may be closed by this pull request
7 tasks
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fg-mindee fg-mindee modified the milestones: 1.0.0, 0.6.0 Jan 10, 2022
@fg-mindee fg-mindee merged commit 0da7ce0 into mindee:main Jan 10, 2022
@felixdittrich92 felixdittrich92 deleted the imgur5k branch January 10, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: docs Related to docs folder ext: tests Related to tests folder module: datasets Related to doctr.datasets type: new feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[datasets] Extend the range of public datasets supported in docTR
2 participants