Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixed typo in installation instructions #901

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

frgfm
Copy link
Collaborator

@frgfm frgfm commented Apr 27, 2022

Hey there 👋

I noticed a small typo introduced in #862 for installation instructions. This PR simply fixes that for both tabs.

Any feedback is welcome!

@felixdittrich92
Copy link
Contributor

Huhu @frgfm
I have integrated this also in #896 😅

@frgfm
Copy link
Collaborator Author

frgfm commented Apr 27, 2022

Oh my bad @felixdittrich92 : that being said, it's better to split PRs, and in #896, you are still missing the quotes (for people using zsh or something else than pure bash, it's needed). So perhaps we should remove the typo fix from #896? What do you think?

@felixdittrich92
Copy link
Contributor

yes you are right 👍 lets do this :)

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @frgfm, thanks for the fix ;)

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #901 (b2a59cd) into main (43e5da3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #901   +/-   ##
=======================================
  Coverage   94.69%   94.69%           
=======================================
  Files         133      133           
  Lines        5377     5377           
=======================================
  Hits         5092     5092           
  Misses        285      285           
Flag Coverage Δ
unittests 94.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43e5da3...b2a59cd. Read the comment docs.

@charlesmindee charlesmindee merged commit 56b914c into mindee:main Apr 27, 2022
@frgfm frgfm deleted the doc-fix branch April 28, 2022 00:47
@felixdittrich92 felixdittrich92 added type: bug Something isn't working topic: documentation Improvements or additions to documentation ext: docs Related to docs folder labels May 2, 2022
@frgfm frgfm added this to the 0.5.2 milestone May 2, 2022
@frgfm frgfm mentioned this pull request Jun 28, 2022
14 tasks
@felixdittrich92 felixdittrich92 mentioned this pull request Sep 26, 2022
85 tasks
@felixdittrich92 felixdittrich92 modified the milestones: 0.5.2, 0.6.0 Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: docs Related to docs folder topic: documentation Improvements or additions to documentation type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants