Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ add url doc parsing #35

Merged
merged 5 commits into from
Jun 16, 2023
Merged

✨ add url doc parsing #35

merged 5 commits into from
Jun 16, 2023

Conversation

sebastianMindee
Copy link
Collaborator

No description provided.

@sebastianMindee sebastianMindee marked this pull request as ready for review June 15, 2023 16:45
ianardee
ianardee reviewed Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@ianardee ianardee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's rename input_doc arguments & variables to input_source, WDYT?

lib/mindee/client.rb Outdated Show resolved Hide resolved
ianardee
ianardee requested changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@ianardee ianardee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a basic unit test of the UrlInputSource class.

@sebastianMindee sebastianMindee merged commit a9dca05 into release/v3 Jun 16, 2023
19 checks passed
@sebastianMindee sebastianMindee deleted the add-doc-from-url branch June 16, 2023 13:16
ianardee pushed a commit that referenced this pull request Jun 29, 2023
@sebastianMindee @ianardee
✨ add url input source (#35)
70ed492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianardee ianardee ianardee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastianMindee @ianardee