Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ladder placement #2797

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Oblomov
Copy link

@Oblomov Oblomov commented Dec 13, 2020

Ladders placed against other ladders while sneaking will copy the
existing ladder's param2, thus allowing vertical construction even in the absence
of walls behind them.

@paramat
Copy link
Contributor

paramat commented Dec 14, 2020

MTG is feature-frozen so we might not be able to accept this.

@rubenwardy
Copy link
Member

I thought it was just gameplay feature frozen, and maintenance is fine?

Ladders placed against other ladders while sneaking will copy the
existing ladder's param2, thus allowing vertical construction even in the absence
of walls behind them.
@Wuzzy2
Copy link
Contributor

Wuzzy2 commented Mar 17, 2021

 	if sneaking and under and under.name:find("^default:ladder_") then

No, just no.

@sfan5
Copy link
Member

sfan5 commented Mar 24, 2021

The approach is not very portable, but stairs also does this and given that there are exactly two ladder nodes in MTG I don't see the issue.

@appgurueu
Copy link
Contributor

The approach is not very portable, but stairs also does this and given that there are exactly two ladder nodes in MTG I don't see the issue.

Groups should be used, both for stairs and for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants