Feature: add source map for easier debugging #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change definitely shouldn't cause the failed tests in CI, the same failures are on the dev branch since this commit, not sure what can I do to help, not really familiar with node.js or qunit :( |
|
Yes I know, I spent hours trying to find why the tests are failing on Travis only, still no clue, it looks like a very odd behaviour of some prebuilt versions of PhantomJS |
|
Fwiw I checked the project repo the other day and ran tests with Is there an easy way to debug the failure? Like launch an interactive debugger on file test? Seems to do something with jQuery.. |
|
I don't know. You got further than me : no error on Windows nor on Fedora. |
bagulho
pushed a commit
to bagulho/jQuery-QueryBuilder
that referenced
this pull request
Jun 24, 2020
* dev: possibility to define a dynamic field Swedish translations (mistic100#865) Hungarian translation (mistic100#862) Remove travis Updated italian translation (mistic100#837) Slovak translation (mistic100#830) Add Github CI Russian translation typos (mistic100#820) Added missing Russian strings in main translation (Translation by Hubbitus) Updated Russian translation (Translation by Hubbitus) Added Lithuanian translation (mistic100#766) Support different placeholders for each input when nb_inputs > 1 (mistic100#764) Added swahili translation (mistic100#754) feat: add source map for easier debugging (mistic100#749) chg: [plugin:chosen] avoid creating useless chosen widget (mistic100#743) Make some methods visible in the doc (mistic100#696 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that having source map file (
.map) makes it way easier to debug errors raised from QueryBuilder when using the minified version of the release. This PR simply uses thesourceMapoption of uglify to generate the source map files in thedist/directory which can then be used by developers if they wish to.Merge request checklist
devand I am issuing the PR todevdistdirectory__localeand__authorfields