Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VIRTS-4690] Add Architecture Header to Sandcat #435

Merged
merged 16 commits into from
Oct 16, 2023

Conversation

bleepbop
Copy link
Contributor

@bleepbop bleepbop commented Sep 11, 2023

Description

Allows users to supply an architecture header to sandcat. This will allow Darwin ARM64 users to successfully compile sandcat without emulation.

Additionally, an architecture key has been added to the sandcat ability file. The frontend can later be modified to use this, so that users can select platform and architecture on the agents page. Currently, all sandcat commands are being listed, but they have been labeled as (ARM64) or (AMD64).

Includes modifications to #423.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Ran all of new agent commands for ARM64, and ran a few abilities with each. Agents compiled successfully and were able to transmit data successfully as well. When running file splunkd, the output verified that the agent was compiled for ARM64.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@bleepbop bleepbop requested a review from clenk September 11, 2023 14:46
elegantmoose
elegantmoose previously approved these changes Sep 26, 2023
@elegantmoose
Copy link
Contributor

Code looked good but I could not test out ARM on my Mac.

Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original PR also updated update-agents.sh and the list of precompiled binaries on the docs page - can you update those as well?

For the docs page, I would prefer adding architecture to the list of parameters and explaining it there instead of at the top of the Options section.

@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clenk clenk merged commit 847539e into master Oct 16, 2023
6 checks passed
@clenk clenk deleted the bleepbop/VIRTS-4690/add-arch-header branch October 16, 2023 16:58
@clenk clenk mentioned this pull request Oct 16, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants