Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizable windows #6

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Resizable windows #6

merged 2 commits into from
Jun 10, 2024

Conversation

marc2911
Copy link
Contributor

@marc2911 marc2911 commented Jun 7, 2024

  • Added resizing of individual windows via GridSplitters

  • codegen now uses file-scoped namespace declarations

  • experimented with implementing minimizing behavior for the CircuitGrid as well, but ultimately discarded it, because it failed due to probable conflicts with the dynamic resizing

  • also tried to remove excess space below circuit grid within the scrolling container, but was also unable to succeed

@linderd
Copy link
Member

linderd commented Jun 8, 2024

Thank you @marc2911 for your contribution.
I will review and test it the next days

@linderd
Copy link
Member

linderd commented Jun 9, 2024

resizing works on my machine (Linux) 👍

@linderd linderd self-assigned this Jun 9, 2024
@linderd
Copy link
Member

linderd commented Jun 9, 2024

Closes #2

Copy link
Member

@linderd linderd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Please open next time two PRs if you are doing two independent changes.

@linderd linderd merged commit 3448d54 into mnm-team:main Jun 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants