Do not delete NoProcess instances in G4HepEmTrackingManager #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In testing AdePT "CPU only" mode using G4HepEm, discovered that use of G4HepEmTrackingManager in same fashion as the AdePT tracking manager resulted in a seg fault at program exit. Traced to destructor of G4HepEmTrackingManager deleting the G4HepEmNoProcess instances it creates. These are important for mapping back to user code information about the process limiting/creating a step. All tracking managers are deleted after the deletion of the G4ProcessTable which nominally owns all instances of G4VProcess. Remove deletion of G4HepEmNoProcess instances in destructor of G4HepEmTrackingManager, leaving their deletion of the destructor of G4ProcessTable. This matches the pattern seen in physics constructor classes.
drbenmorgan
added a commit
to drbenmorgan/celer-adept
that referenced
this pull request
Jul 31, 2024
A small issue was identified G4HepEmTrackingManager that resulted in a segfault at G4RunManager destruction due to a double deletion of G4HepEmNoProcess objects: mnovak42/g4hepem#103 Though this is merged to master, we can't rely on installs having this latest version. Temporarily import latest implementation of G4HepEmTrackingManager, using this in place of whatever we get from G4HepEM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing AdePT "CPU only" mode using G4HepEm, discovered that use of
G4HepEmTrackingManagerin same fashion as the AdePT tracking manager resulted in a segmentation fault at program exit. This was traced to the destructor ofG4HepEmTrackingManagerdeleting theG4HepEmNoProcessinstances it creates. These are important for mapping back to user code information about the process limiting/creating a step. All tracking managers are deleted byG4RunManagerafter the deletion ofG4ProcessTablewhich nominally owns all instances ofG4VProcess.Remove deletion of
G4HepEmNoProcessinstances in destructor ofG4HepEmTrackingManager, leaving their deletion of the destructor of G4ProcessTable. This matches the pattern seen in Geant4's physics constructor classes.