bridge-github: remove the VFS and simplify server startup #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samoht
force-pushed
the
remove-bridge-vfs
branch
from
8735d90
to
2241a25
Compare
The VFS was useful for debugging but not really useful in practice. Depending on the full Datakit_conduit was not really useful as well, and it was causing an unecessary dependency towards datakit-server. Signed-off-by: Thomas Gazagnaire <thomas@gazagnaire.org>
samoht
force-pushed
the
remove-bridge-vfs
branch
from
2241a25
to
5ff589a
Compare
samoht
added a commit
to samoht/datakit
that referenced
this pull request
May 2, 2017
--no-listen is now the default argument as there is no listening option anymore since moby#535 Signed-off-by: Thomas Gazagnaire <thomas@gazagnaire.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VFS was useful for debugging but not really useful in practice. Depending
on the full Datakit_conduit was not really useful as well, and it was causing
an unecessary dependency towards datakit-server.
Signed-off-by: Thomas Gazagnaire thomas@gazagnaire.org