refactor #5017

mochajs · Jul 8, 2024 · 5a65f9c · 5a65f9c
1 parent 11a0615
commit 5a65f9c
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 7 deletions.
diff --git a/bin/mocha.js b/bin/mocha.js
diff --git a/lib/reporters/json.js b/lib/reporters/json.js
@@ -78,16 +78,16 @@ function JSONReporter(runner, options = {}) {
 
     runner.testResults = obj;
 
-    var optionsIndentSize;
-    if (options.reporterOption && 'indentSize' in options.reporterOption) {
-      optionsIndentSize = options.reporterOption.indentSize;
+    options.indentation = options.reporterOption?.indentSize ?? 2; // Default indenation
+
+    var json;
+
+    if (options.indentation === '\\t') {
+      json = JSON.stringify(obj, null, '\t');
     } else {
-      optionsIndentSize = 2; // Default Indentation size
+      json = JSON.stringify(obj, null, parseInt(options.indentation, 10));
     }
 
-    var indentSize = parseInt(optionsIndentSize, 10); // Cast string to int
-
-    var json = JSON.stringify(obj, null, indentSize);
     if (output) {
       try {
         fs.mkdirSync(path.dirname(output), {recursive: true});

diff --git a/test/reporters/json.spec.js b/test/reporters/json.spec.js
@@ -229,5 +229,19 @@ describe('JSON reporter', function () {
         'file output not supported in browser'
       );
     });
+
+    it('should set options.indentation correctly', function () {
+      var options = {indentation: 4};
+      var mochaReporter = new mocha._reporter(runner, options);
+
+      expect(mochaReporter.options.indentation, 'to be', 4);
+    });
+
+    it('should set options.indentation correctly with a tab', function () {
+      var options = {indentation: '\t'};
+      var mochaReporter = new mocha._reporter(runner, options);
+
+      expect(mochaReporter.options.indentation, 'to be', '\t');
+    });
   });
 });