Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error in hardhat deployed func, use new Hardhat deploy func #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0xemrekaya
Copy link

@0xemrekaya 0xemrekaya commented Feb 20, 2024

Description:
This Pull Request includes the following changes to use the new deploy features of Hardhat v2.0.0^:

  • The deployContract() function is used instead of the old getContractFactory() and deploy() functions.
  • New getAddress() function is used instead of old address.

WHY?
In Hardhat v2.0.0, a number of changes were made to the deploy process, including the deployContract and waitForDeployment functions. So the old code was not working, so I updated it with the new version.

the old code has a error:
image

If you need more information about Hardhat v2.0.0^ check this guides: https://hardhat.org/hardhat-runner/docs/guides/deploying

@0xemrekaya
Copy link
Author

@fede2442 Could you check this PR?, thanks sir.

@0xemrekaya 0xemrekaya changed the title Update the deploy contract with Hardhat new version fix: update the deploy contract with Hardhat new version Mar 24, 2024
@0xemrekaya 0xemrekaya changed the title fix: update the deploy contract with Hardhat new version fix: error in hardhat deployed func, use new Hardhat deploy func Mar 24, 2024
@joshuanwankwo
Copy link
Contributor

Checked and figured out that hardhat included hardhat ignition into their building and deployment flow, we'll need to update the entire article.

@0xemrekaya thanks for pointing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants