Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include isdsts field in data #1057

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ethanshar
Copy link

isdsts field is missing from data
This PR adds it to the relevant data tasks

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 25, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ethanshar / name: Ethan Sharabi (db2a6b4)

@gilmoreorless
Copy link
Member

Thanks for the PR, but I'm a little confused about its purpose.

Moment Timezone doesn't add the isdst field to the data files because the library doesn't use that field for calculations. There are no changes to the calculation code here that would require the data. Could you elaborate about why this is needed?

Also, this PR only adds the field to the unpacked data file, but not the packed file that is actually shipped with the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants