Added missed ssl options for ciphers and ecdhCurve
#1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…blish ssl handshake with mongo server which is used certificate with ECDH curve;
daprahamian
approved these changes
Dec 4, 2017
daprahamian
added a commit
that referenced
this pull request
Dec 4, 2017
…dhCurve` Adds missingssl options that are required for mongodb-core to establish ssl handshake with mongo server which is used certificate with ECDH curve Ports #1579 to 3.0.0 Adds missingssl options that are required for mongodb-core to establish ssl handshake with mongo server which is used certificate with ECDH curve
daprahamian
added a commit
that referenced
this pull request
Dec 4, 2017
…dhCurve` Adds missingssl options that are required for mongodb-core to establish ssl handshake with mongo server which is used certificate with ECDH curve Ports #1579 to 3.0.0
daprahamian
added a commit
that referenced
this pull request
Dec 5, 2017
…dhCurve` Adds missingssl options that are required for mongodb-core to establish ssl handshake with mongo server which is used certificate with ECDH curve Ports #1579 to 3.0.0
mbroadst
pushed a commit
that referenced
this pull request
Dec 5, 2017
…dhCurve` Adds missingssl options that are required for mongodb-core to establish ssl handshake with mongo server which is used certificate with ECDH curve Ports #1579 to 3.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is related with this and this.
In short, is it currently impossible to do ssl handshake with mongos/mongod if it is used certificate with ECDH curve. This is due to recently added
ecdhCurvessl option to nodejs. Here we are passing this option andcipheroption tomongodb-coreAlso, I was faced with Promise error about missed
returnstatement while runned tests.