Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-6241): allow Binary as local kms provider key for auto encryption #4165

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Jun 28, 2024

Description

What is changing?

This fixes the compile_ts task in mongosh's CI: https://evergreen.mongodb.com/task/mongosh_linux_unit_compile_ts_667efa29aa31110007944584_24_06_28_18_00_09/0?redirect_spruce_users=true.

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

The LocalKMSProviderConfiguration's key property accepts Binary for auto encryption

In #4160 we fixed a type issue where a local KMS provider at runtime accepted a BSON Binary instance but the Typescript inaccurately only permitted Buffer and string. The same change has now been applied to AutoEncryptionOptions.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review June 28, 2024 19:30
@nbbeeken nbbeeken self-assigned this Jun 28, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 28, 2024
@nbbeeken nbbeeken merged commit d85f827 into main Jun 28, 2024
23 of 26 checks passed
@nbbeeken nbbeeken deleted the fix-mongosh-ci branch June 28, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants