0px if not browser #1242
Merged
0px if not browser #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seungpark
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
this works for me 👍 i was thinking in the sidenav where we call this but this is actually better 👍 thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories/Links:
DOP-5000
Unfortunately I can't really replicate this behavior in local dev, but in preprd you see that
scrollY = undefinedon initial load which causes the bottom 3 links to not show up until you scroll. This PR sets it to 0 when it's being built so it is not undefined on initial load. Check out the<div>with iddocs-side-nav-container.Current Behavior:
Landing prod
Landing preprd
Staging Links:
Landing Staging
Notes:
README updates