Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noemptysecondlines check #133

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

andrewnicols
Copy link
Contributor

Remove noemptysecondlines check
Already covered by:

  • moodle.Files.BoilerplateComment.NoPHP
  • PSR12.Files.FileHeader.HeaderPosition

Already covered by:
* moodle.Files.BoilerplateComment.NoPHP
* PSR12.Files.FileHeader.HeaderPosition
@stronk7
Copy link
Member

stronk7 commented Mar 13, 2024

This is fun...

the other day, when doing all the PSR12 changes to moodle-cs I realised that the rules are 100% the opposite one. Moodle requires a blank like. PSR forbids it. :-)

Edited: Gah, ignore the above, I was mixing repositories! It was not Moodle!

@stronk7 stronk7 self-assigned this Mar 13, 2024
@stronk7 stronk7 assigned andrewnicols and unassigned stronk7 Mar 13, 2024
@stronk7
Copy link
Member

stronk7 commented Mar 13, 2024

FYI: I'm going to merge this (once GHA is green) by squashing the 3 current commits. Reason being that I already had fixed the "final" tests some minutes ago while advancing with the php83 epic.

@stronk7 stronk7 merged commit 90c24e5 into moodlehq:main Mar 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants