Remove all checks for define() #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
andrewnicols
added a commit
to andrewnicols/moodle-local_moodlecheck
that referenced
this pull request
Mar 22, 2024
These checks never worked. The `get_defines()` method built a list of
definitions, added them to a `$defines` array, but return
`$this->defines` instead.
Furthermore there would be pandamonium if we actually fixed this because
we use constants in scripts all over Moodle with the same value, for
example:
```
define('CLI_SCRIPT', true);
```
andrewnicols
force-pushed
the
removedefinechecks
branch
from
534b65c
to
0a39342
Compare
|
Whops, this is conflicting, would you take a look to it, please? |
These checks never worked. The `get_defines()` method built a list of
definitions, added them to a `$defines` array, but return
`$this->defines` instead.
Furthermore there would be pandamonium if we actually fixed this because
we use constants in scripts all over Moodle with the same value, for
example:
```
define('CLI_SCRIPT', true);
```
andrewnicols
force-pushed
the
removedefinechecks
branch
from
0a39342
to
48ff9d3
Compare
|
Rebased :) |
stronk7
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These checks never worked. The
get_defines()method built a list of definitions, added them to a$definesarray, but return$this->definesinstead.Furthermore there would be pandamonium if we actually fixed this because we use constants in scripts all over Moodle with the same value, for example: