Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Girazoki support both pre and post 0.9.16 anchoring logics for native token #1232

Conversation

girazoki
Copy link
Collaborator

@girazoki girazoki commented Jan 31, 2022

What does it do?

It adds support for mapping both pre and post 0.9.16 anchoring changes to the same token (in this case, the native token).

The reanchoring logic change will stop from marking us see our token as

MultiLocation {
  parents: 1,
  interior: X2(Parachain(para_id), PalletInstance(balances_pallet))
  }

To make it see it as

MultiLocation {
  parents: 0,
  interior: X1(PalletInstance(balances_pallet)
 }

This PR does yet not add the possibility of transferring the local token for Moonriver and Moonbeam. I wanted this review to be easier, so I will make a follow up PR enabling transfer of the local asset in XCM

What important points reviewers should know?

Is there something left for follow-up PRs?

Adding the possibility of transferring the local token for Moonriver and Moonbeam

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@girazoki girazoki marked this pull request as draft January 31, 2022 12:13
@girazoki girazoki marked this pull request as ready for review January 31, 2022 14:14
@girazoki girazoki added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes A0-pleasereview Pull request needs code review. D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Jan 31, 2022
@girazoki
Copy link
Collaborator Author

Merged in #1274

@girazoki girazoki closed this Feb 11, 2022
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants