Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumers test #356

Merged
merged 19 commits into from
Dec 6, 2023
Merged

Consumers test #356

merged 19 commits into from
Dec 6, 2023

Conversation

girazoki
Copy link
Collaborator

@girazoki girazoki commented Dec 1, 2023

This PR brings paritytech/polkadot-sdk#1976 to our depencies but we still dont have a way to test it as we dont use pallets with locks. However I took the opportunity to test consumers are correct with holds in our pooled staking pallet

@girazoki
Copy link
Collaborator Author

girazoki commented Dec 1, 2023

Update: I might be able to test locks with XCM, although its quite a complex case. I will create an issue for this

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Coverage Report

(master)

@@                Coverage Diff                 @@
##           master   consumers-test      +/-   ##
==================================================
- Coverage   73.73%           73.70%   -0.03%     
  Files          89               89              
- Lines       20201            20195       -6     
==================================================
- Hits        14894            14884      -10     
+ Misses       5307             5311       +4     
Files Changed Coverage
/client/consensus/src/consensus_orchestrator.rs 77.46% (-0.44%) 🔽
/container-chains/templates/frontier/node/src/chain_spec.rs 71.74% (-0.15%) 🔽
/container-chains/templates/frontier/runtime/src/lib.rs 43.05% (-0.26%) 🔽
/container-chains/templates/simple/node/src/chain_spec.rs 68.48% (-0.19%) 🔽
/container-chains/templates/simple/runtime/src/lib.rs 58.21% (-0.10%) 🔽
/node/src/chain_spec.rs 89.93% (-0.04%) 🔽
/pallets/inflation-rewards/src/lib.rs 90.91% (-2.27%) 🔽
/pallets/registrar/src/lib.rs 92.93% (+0.25%) 🔼
/pallets/services-payment/src/lib.rs 84.56% (+0.67%) 🔼
/runtime/dancebox/src/lib.rs 79.61% (-0.03%) 🔽

Coverage generated Tue Dec 5 16:45:04 UTC 2023

@girazoki girazoki added a0-pleasereview Pull request needs code review. I4-tests 🎯 Tests need fixing, improving or augmenting. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes labels Dec 5, 2023
@girazoki girazoki added the not-breaking Does not need to be mentioned in breaking changes label Dec 5, 2023
@girazoki girazoki merged commit 1fc6b2a into master Dec 6, 2023
25 checks passed
@girazoki girazoki deleted the consumers-test branch December 6, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes I4-tests 🎯 Tests need fixing, improving or augmenting. not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants