-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consumers test #356
Merged
Merged
Consumers test #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update: I might be able to test locks with XCM, although its quite a complex case. I will create an issue for this |
Coverage Report@@ Coverage Diff @@
## master consumers-test +/- ##
==================================================
- Coverage 73.73% 73.70% -0.03%
Files 89 89
- Lines 20201 20195 -6
==================================================
- Hits 14894 14884 -10
+ Misses 5307 5311 +4
|
girazoki
added
a0-pleasereview
Pull request needs code review.
I4-tests 🎯
Tests need fixing, improving or augmenting.
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
labels
Dec 5, 2023
fgamundi
approved these changes
Dec 5, 2023
Agusrodri
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a0-pleasereview
Pull request needs code review.
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
I4-tests 🎯
Tests need fixing, improving or augmenting.
not-breaking
Does not need to be mentioned in breaking changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings paritytech/polkadot-sdk#1976 to our depencies but we still dont have a way to test it as we dont use pallets with locks. However I took the opportunity to test consumers are correct with holds in our pooled staking pallet