-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAF-13167] Implement outer #39
Conversation
Prior to the code review,
|
Check all the texts in the codes again. I'll resume the review after that. |
And it is not about this operation or PR, but is there a reason there's a single commit? Did you squash it? Any reason? |
|
@kyeonghwanryu There was no strict reason. I just thought that too many commits would hamper readability. I will not use squash later. |
So please don't. |
There is static code analysis you have to run but I think I forgot to deliver it so please do this if you didn't:
|
… update test cases
…and 'make analyze'
driver/outer_driver.hpp
Outdated
#include <../test/verify.hpp> | ||
|
||
template <typename Tgpu, typename Tcheck> | ||
int32_t mloSumForwardRunHost(miopenTensorDescriptor_t input1Desc, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
int32_t mloSumForwardRunHost(miopenTensorDescriptor_t input1Desc, | |
int32_t mloOuterForwardRunHost(miopenTensorDescriptor_t input1Desc, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replaced "mloSumForwardRunHost" with "mloOuterForwardRunHost".
Good work. 고생하셨습니다. |
Added an outer operation kernel with a solver.
Added driver tests and gtests for the outer operation.
Compared to ROCm PyTorch, there is a performance improvement in some cases.
[benchmark result compared to ROCm pytorch](https://morehio-my.sharepoint.com/:x:/r/personal/kyeonghwan_ryu_moreh_io/_layouts/15/Doc.aspx?sourcedoc=%7B6BF2D5F6-D6F2-47D7-94B5-DE831CA02884%7D&file=ROCm%20pytorch%20vs%20moDNN%20pytorch%20%20(outer).xlsx&action=default&mobileredirect=true&wdsle=0)
Geomean of all cases