Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No slash in links #801

Merged
merged 7 commits into from
Oct 27, 2023
Merged

No slash in links #801

merged 7 commits into from
Oct 27, 2023

Conversation

alaflaquiere
Copy link
Contributor

@alaflaquiere alaflaquiere commented Oct 27, 2023

Description

Following Issue 3514 on the MoveIt repo, I suggest to explicitly list the characters one shouldn't use in a link name, including the / used for subframes.

The PR amends the pages that mention link names and prefixes (i.e. urdf_srdf_tutorial.rst and multiple_robot_arms_tutorial.rst). It also slightly improves the formatting of the list of characters to avoid for the sake of readability.

Copy link
Contributor

@simonschmeisser simonschmeisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase your branch to the current master

@tylerjw tylerjw merged commit 1c0d3df into moveit:master Oct 27, 2023
4 of 5 checks passed
@alaflaquiere alaflaquiere deleted the no_slash_in_links branch October 28, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants